fix(rbac): allow tenant finalizer updates - #214
Draft
GatewayJ wants to merge 1 commit into
Draft
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Part of #206.
Summary of Changes
updateverb on thetenants/finalizerssubresourceChecklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change) — N/A; this repository does not currently containCHANGELOG.mdImpact
Update impact
rbac.create=falsemust addupdateonrustfs.comtenants/finalizersto their externally managed ClusterRole before upgrading the Operator.Verification
make pre-commit cargo test --manifest-path e2e/Cargo.toml --test finalizer_rbac_manifestAdditional Notes
This PR is intentionally independent from the security-context and OpenShift delivery changes for #206 and can be reviewed and released separately.
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.