fix(console): prevent pool volume count overflow - #223
Draft
GatewayJ wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Fixes rustfs/backlog#1095
Summary of Changes
PoolDetails.total_volumestoi64Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)Impact
total_volumesfromint32toint64; the JSON field remains numericVerification
Additional Notes
Every
i32 * i32result fits exactly ini64, so widening preserves the real volume count without clamping. Values above JavaScript's safe-integer range remain a theoretical client-side limitation; changing the field to a string would break the existing Console contract and is outside this fix.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.