fix: SMTP reliability and process exit code#17
Merged
Conversation
- Check mpsc::send result in SMTP session; respond 451 on channel failure instead of silently acknowledging with 250 OK (H-1) - Propagate SMTP/HTTP bind errors from select! as anyhow::bail instead of logging and returning Ok(()) with exit code 0 (H-2) - Send 421 response before dropping connections at session limit instead of silently closing the TCP connection (L-3) - Update session limit test to expect 421 response Closes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mpsc::sendresult in SMTP session; respond451on channel failure instead of silently acknowledging with250 OKselect!asanyhow::bailinstead of logging and returningOk(())with exit code 0421response before dropping connections at session limit instead of silently closing the TCP connectionTest plan
smtp_session_limit_rejects_excessupdated to assert421responseCloses #14