fix: SMTP command ordering, WebSocket cleanup, inbox a11y#19
Merged
Conversation
- Track EHLO/HELO greeting state in SMTP session; reject MAIL FROM with 503 Bad Sequence if client hasn't greeted yet (M-1) - Track current WebSocket instance and reconnect timer in module scope; close socket and clear timer on component cleanup to prevent leaks during HMR/remount (L-1) - Add onKeyDown handler for Enter/Space on inbox rows so keyboard-only users can activate messages, matching the role="button" semantics (L-2) Closes #16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="button"semantics)Test plan
Closes #16