Open
Conversation
Splits the retention background loop into run_retention_tick so tests can drive the actual scheduler logic deterministically by injecting the "now" timestamp. Adds unit tests covering: - no-op when both retention_hours and max_messages are disabled - time-based purge removes rows older than the cutoff - max_messages trim removes the expected oldest rows - MessageDelete WsEvents match the deleted ids, including combined purge + trim passes Previously these paths were only exercised via repository-level tests, leaving the scheduler's event emission and branching untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary