fix(firmware): display-less DevKitC-1 build overlay + stale IDF v5.2 doc refs (#1308)#1311
Merged
Merged
Conversation
… IDF v5.2 refs to v5.4 The ADR-045 display probe false-positives on display-less ESP32-S3-DevKitC-1 boards (SH8601 init 'succeeds' against floating pins), so main.c skips the RuView#893 MGMT+DATA promiscuous upgrade and CSI yield collapses to 0 pps. sdkconfig.defaults.devkitc compiles display support out, making has_display constant-false so the ruvnet#893 upgrade always applies. Hardware-verified on 2x DevKitC-1-N16R8: 0 pps -> steady 40-45 pps. Also updates the Quick Start build commands and badge from espressif/idf:v5.2 to v5.4 — current source uses esp_driver_uart (IDF v5.3+) and no longer builds under v5.2; CI already uses v5.4. Addresses ruvnet#1308 Co-Authored-By: claude-flow <ruv@ruv.net>
Owner
|
Merged via #1332 — hardware verification on 2× DevKitC-1-N16R8 appreciated. One fix applied on the integration branch: the overlay header's copy-paste build command still referenced |
pchaganti
pushed a commit
to pchaganti/ax-ru-view
that referenced
this pull request
Jul 14, 2026
…CHANGELOG - sdkconfig.defaults.devkitc: header build command idf v5.2 -> v5.4 (source needs esp_driver_uart, IDF >=5.3 — same reason the PR fixed the README refs) - engine/lib.rs: separate doc comments — set_room_adapter's ADR-150 adapter/witness doc had merged into set_multistatic_config's doc - ui: apply stored bearer token at api.service.js module load instead of QuickSettings.init — services + dashboard tab dispatch their first /api/v1/* requests before initializeEnhancements() runs, so the first requests on every load went out without the Authorization header - CHANGELOG: Unreleased entries for ruvnet#1308/ruvnet#1309/ruvnet#1310 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1308
What
firmware/esp32-csi-node/sdkconfig.defaults.devkitc— a build overlay for display-less boards (ESP32-S3-DevKitC-1 and similar) that setsCONFIG_DISPLAY_ENABLE=n, makinghas_displayconstant-false so the RuView#893 MGMT+DATA CSI upgrade always applies.espressif/idf:v5.2references in the firmware README (Quick Start badge + build commands) tov5.4: current source usesesp_driver_uart(IDF v5.3+) and fails CMake resolution under v5.2; CI already builds with v5.4. Later sections of the README already said v5.4 — this aligns the rest.Why
On a stock DevKitC-1 the ADR-045 display probe false-positives (
SH8601 panel init OKagainst floating pins), sodisplay_is_active()returns true andmain.cskipscsi_collector_enable_data_capture()— CSI yield collapses to 0 pps, the exact symptom #893 fixed. See #1308 for full boot logs and analysis of why neither shipped S3 prebuilt works on these boards.This PR is the minimal user-side unblock. It deliberately does not attempt the deeper fixes suggested in #1308 (hardening the probe with a panel-ID readback, or an NVS
display=0override) — happy to follow up on either if maintainers have a preference.Verification
Hardware-verified on 2× ESP32-S3-DevKitC-1-N16R8: built with the overlay under
espressif/idf:v5.4(Docker), flashed, and confirmed the boot log now showsCSI filter upgraded to MGMT+DATA (no display, RuView#893)with steady 40–45 pps yield (was 0 pps), presence/motion detection active, and the sensing server holding a stableesp32source with zero fusion errors.🤖 Generated with claude-flow