feat(signal): extract a signed BVP so Doppler direction survives - #1816
Open
clonea1 wants to merge 1 commit into
Open
feat(signal): extract a signed BVP so Doppler direction survives#1816clonea1 wants to merge 1 commit into
clonea1 wants to merge 1 commit into
Conversation
extract_bvp takes a real-valued, amplitude-only input and keeps only the
magnitude of the FFT output, then folds doppler_freq.abs() into the velocity
bins. Direction is therefore unavailable from that path -- and not as a tuning
shortcut that a better post-processing step could undo.
A real-valued signal's FFT magnitude is symmetric about zero frequency:
|X(-f)| == |X(f)| for real x
So approach and retreat produce identical spectra. The information is not
attenuated or noisy, it is absent, and no amount of downstream work recovers
it. Anything built on that output can report that motion occurred but never
which way it went.
extract_bvp_signed takes temporal COMPLEX CSI -- amplitude and phase together
-- so the spectrum is no longer constrained to be symmetric and the sign of the
Doppler shift is preserved. Added alongside the existing function rather than
replacing it: callers with only amplitude available keep working unchanged, and
the choice of which to use is made where the input format is known.
Three tests cover the property that matters: a synthetic approaching source and
a receding one must produce opposite signs, which the amplitude-only path
cannot distinguish by construction.
Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_bvp takes a real-valued, amplitude-only input and keeps only the
magnitude of the FFT output, then folds doppler_freq.abs() into the velocity
bins. Direction is therefore unavailable from that path -- and not as a tuning
shortcut that a better post-processing step could undo.
A real-valued signal's FFT magnitude is symmetric about zero frequency:
So approach and retreat produce identical spectra. The information is not
attenuated or noisy, it is absent, and no amount of downstream work recovers
it. Anything built on that output can report that motion occurred but never
which way it went.
extract_bvp_signed takes temporal COMPLEX CSI -- amplitude and phase together
-- so the spectrum is no longer constrained to be symmetric and the sign of the
Doppler shift is preserved. Added alongside the existing function rather than
replacing it: callers with only amplitude available keep working unchanged, and
the choice of which to use is made where the input format is known.
Three tests cover the property that matters: a synthetic approaching source and
a receding one must produce opposite signs, which the amplitude-only path
cannot distinguish by construction.
Rebased onto current
mainbefore opening: staged before today's seven merges, so it needed replaying to avoid reading as a revert of them. Clean rebase, no files deleted.