feat(ui): add the Tools menu that reaches the diagnostic and field-test pages - #1835
Draft
clonea1 wants to merge 1 commit into
Draft
feat(ui): add the Tools menu that reaches the diagnostic and field-test pages#1835clonea1 wants to merge 1 commit into
clonea1 wants to merge 1 commit into
Conversation
…st pages Several shipped pages are reachable only by typing their URL, because the main nav has no entry for them. This adds a Tools dropdown grouping them under Field tests, Diagnostics and Views. **This PR is wiring only and MUST merge last.** It adds no pages. Eight of the eleven links point at pages that arrive with other PRs, so merging this first would put dead entries in the nav. Three are already present here (`viz.html`, `observatory.html`, `pose-fusion.html`) and would work today. Deliberately kept as one small follow-up rather than splitting a menu line into each page's PR: a nav menu is a single coherent thing, and assembling it three lines at a time across eight PRs produces eight conflicts in one file for no benefit. Reviewing it once, last, against the pages that actually landed is both safer and less work. The dropdown is plain markup plus a small inline handler -- no framework, no build step, no dependency. It closes on outside click (including touch, where there is no pointer to move away) and on Escape, and carries the aria-haspopup / aria-expanded / role=menu wiring so it is reachable without a mouse. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several shipped pages are reachable only by typing their URL, because the main
nav has no entry for them. This adds a Tools dropdown grouping them under Field
tests, Diagnostics and Views.
This PR is wiring only and MUST merge last. It adds no pages. Eight of the
eleven links point at pages that arrive with other PRs, so merging this first
would put dead entries in the nav. Three are already present here
(
viz.html,observatory.html,pose-fusion.html) and would work today.Deliberately kept as one small follow-up rather than splitting a menu line into
each page's PR: a nav menu is a single coherent thing, and assembling it three
lines at a time across eight PRs produces eight conflicts in one file for no
benefit. Reviewing it once, last, against the pages that actually landed is
both safer and less work.
The dropdown is plain markup plus a small inline handler -- no framework, no
build step, no dependency. It closes on outside click (including touch, where
there is no pointer to move away) and on Escape, and carries the
aria-haspopup / aria-expanded / role=menu wiring so it is reachable without a
mouse.
Merge order
This is the last piece. Each link below arrives with another PR; merging this
before them leaves dead entries in the nav.
ui-ground-truth-capturemesh.html/mesh3d.htmlnot yet submittedserver-emitter-triageui-world3dmainHappy to hold this as a draft until the others land, or to trim it to only the
three entries that work today and follow up — whichever you prefer. Flagging it
now mainly so the pages do not merge and then sit unreachable.