fix(websocket): handle broadcast Lagged error + ping keepalive#376
Open
schwarztim wants to merge 1 commit intoruvnet:mainfrom
Open
fix(websocket): handle broadcast Lagged error + ping keepalive#376schwarztim wants to merge 1 commit intoruvnet:mainfrom
schwarztim wants to merge 1 commit intoruvnet:mainfrom
Conversation
When the broadcast channel's recv() returns Lagged (client fell behind), the server previously treated it as fatal and dropped the connection. The client immediately reconnected, creating a visible 2-4s freeze cycle. Fix: - Lagged error: skip missed frames with continue instead of break - Add 30s ping/pong keepalive to prevent reverse proxy idle timeouts (Caddy, nginx default 60s idle → drops long-lived WS connections) Tested with 11 ESP32-S3 nodes streaming at ~20fps per node: sustained 154 frames over 8 seconds, zero disconnects. Fixes dashboard freezing reported in multi-node deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the broadcast channel's recv() returns Lagged (client fell behind), the server previously treated it as fatal and dropped the connection. The client immediately reconnected, creating a visible 2-4s freeze cycle on the dashboard.
Fix:
continueinstead ofbreakTesting: 11 ESP32-S3 nodes streaming at ~20fps per node, sustained 154 frames over 8s, zero disconnects.
Fixes dashboard freezing in multi-node deployments.