fix(mobile): Clean up sockets when simulation starts#380
Open
Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Open
fix(mobile): Clean up sockets when simulation starts#380Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Conversation
When the server URL is cleared, close the active WebSocket and cancel pending reconnects so simulation mode does not race with stale network state. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainTesting
npm --prefix ui/mobile test -- --runInBand src/__tests__/services/ws.service.test.ts -t "cleans up active sockets and pending reconnects when switching to simulation mode"Context
Replacement for closed PR #240 with still-real diff on current
main.