Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds SwiftLint linting support to the repository with a Makefile entrypoint and CI integration, so style checks can run consistently locally and in GitHub Actions.
Changes:
- Add
make lintandmake lint-citargets that run SwiftLint with a shared.swiftlint.ymlconfig. - Introduce a minimal SwiftLint configuration (currently only enforcing
file_length) with explicit include/exclude paths. - Add a new
lintjob to the existingTestsGitHub Actions workflow to run SwiftLint in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Adds lint / lint-ci targets for running SwiftLint locally and in CI. |
| .swiftlint.yml | Defines included/excluded paths and enables only the file_length rule with thresholds. |
| .github/workflows/test.yaml | Adds a lint job that installs SwiftLint via Homebrew and runs make lint-ci. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .PHONY: lint lint-ci | ||
|
|
||
| lint: | ||
| $(SWIFTLINT) lint --config .swiftlint.yml --quiet --no-cache |
Comment on lines
+14
to
+20
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Install SwiftLint | ||
| run: brew list swiftlint >/dev/null 2>&1 || brew install swiftlint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.