Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR addresses CI build failures by ensuring SwiftUI preview-only code is correctly excluded from non-Debug builds and by updating the GitHub Actions mobile build step to compile the iOS app using the Release configuration (where DEBUG is not defined).
Changes:
- Move the
#endifinSessionsList.swiftto ensure#Previewblocks (and their supporting preview-only state) are fully wrapped in#if DEBUG. - Update the
build-mobileGitHub Actions step to buildRxCodeMobilewith-configuration Releaseto catch Debug-only code that accidentally leaks into production builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RxCodeMobile/Views/SessionsList.swift | Fixes conditional compilation so preview code doesn’t compile in Release, preventing Release build errors. |
| .github/workflows/test.yaml | Builds the iOS app in Release during CI to surface missing/incorrect #if DEBUG guards. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
🎉 This PR is included in version 1.9.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.