Conversation
# Conflicts: # android/app/src/main/res/values-de/strings.xml # android/app/src/main/res/values-pl/strings.xml # android/app/src/main/res/values-ru/strings.xml # android/app/src/main/res/values-zh/strings.xml
|
Reviewed on-device, looks good to my german eyes. |
|
Thanks @bhelm. Reviewed the whole delta. The headline: the red check is not yours, and the two code changes are both genuine bug fixes. One blocking item on the new test file. The failing check
I merged current main into your head locally: clean, zero conflicts. On that merged tree: A rebase onto main clears the red. Nothing to change for it. The two code changes are real fixesAndroid, uiString(R.string.l10n_today_screen_baselines_learned_on_device_over_14_359f6812) +
" signal against a typical adult range, not medical advice."So every locale rendered that sentence half-translated, not just German. Routing the whole sentence through iOS, Blocking: the new test file never runs
Worth doing rather than dropping, because one of those 8 would have caught the next item. Non-blockingGerman terminology splits on the exact concept this PR is about. After the change:
Two adjacent VoiceOver labels for the same thing now disagree, and Android disagrees with iOS. Your 8 dead strings. What I checked mechanically
What I cannot checkGerman prose quality. The terminology table above is a consistency observation, not a judgement on which wording reads better, and I will take your call on it. Rebase, convert the test, and I will merge. |
Summary
German language concept
Verification
python3 Tools/tests/test_german_today_localization.pypython3 Tools/test_home_i18n.pypython3 Tools/test_i18n_audit.pypython3 Tools/i18n_audit.py --ci origin/main./android/gradlew -p android :app:testFullDebugUnitTest --tests com.noop.ui.GermanLocalizationTest