Skip to content

fix: persist sessions after response errors#865

Merged
ryanfowler merged 1 commit into
mainfrom
fix/session-save-error-paths
Jul 14, 2026
Merged

fix: persist sessions after response errors#865
ryanfowler merged 1 commit into
mainfrom
fix/session-save-error-paths

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • save session cookie changes even when redirect, replay, digest, signing, or later request processing fails
  • preserve dry-run behavior by skipping session writes
  • cover invalid redirects and malformed dry-run sessions with integration tests

Validation

  • cargo fmt --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --locked --all-features --test http session_cookies_persist_after_invalid_redirect
  • cargo test --locked --all-features --test http dry_run_leaves_corrupted_session_unchanged

@ryanfowler ryanfowler enabled auto-merge July 14, 2026 11:22
@ryanfowler ryanfowler merged commit be9532f into main Jul 14, 2026
4 checks passed
@ryanfowler ryanfowler deleted the fix/session-save-error-paths branch July 14, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant