Open
Conversation
* Added lots of dyns * Removed unused whitespace. * Removed rust-toolchain because stable rust compiles the project. * Fixed Doc-tests with ignore keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi friend,
I came across your project today and found it neat so I cloned the repo and messed around with it. Here's some of the updates I found to make clippy and the recent stable version of rust happy.
Here's the brief summary of changes:
There's still a bunch of unused code warnings but I figure this is still a WIP so I didn't touch those.
The reason there's so many changes is because I removed (most) unused whitespace. If you're unhappy with that, I'm okay with reverting that.
Also, I notice that the contributing guidelines mention running
cargo fmt --all. I ran this after my changes and it resulted in 1423 deletions and 2139 additions.Let me know if there's anything you'd like me to change.
Thanks,