Open
Conversation
huyfififi
approved these changes
Jun 10, 2025
| return 0; | ||
| } | ||
| int maxProfit = 0; | ||
| for (int i = 0; i < prices.length; i++) { |
There was a problem hiding this comment.
nit: 私だったらiとjをsell_i, buy_iとしてもう少し情報を乗せるかなと思いました。
The Art of Readable Codeにそんなことが載っていたな...と思い読み返してみたところ、
...But sometimes there are better iterator names than i, j, and k.
とし、3重ループの例を挙げて
if (clubs[i].members[k] == users[j])
とするよりも
if (clubs[club_i].members[member_i] == users[user_i])
とした方がわかりやすいと指摘されていました。Best Time to Buy and Sell Stockの場合同じpricesにアクセスしているので、The Art of Readable Codeの例とは若干設定が異なるのですが、参考まで。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題：https://leetcode.com/problems/best-time-to-buy-and-sell-stock/