Skip to content

Fix payout status alert crash on rewards without a funds transfer, remove dead dashboard prop #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Coleton (Locrian24) wants to merge 1 commit into from
Closed

Fix payout status alert crash on rewards without a funds transfer, remove dead dashboard prop #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/mint-components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- \<sqm-payout-status-alert>
- Fixed a crash when a redeemed reward has no `partnerFundsTransfer`, which is the
case for rewards that never resulted in a payout. This matches the documented
behaviour in `sqm-payout-status-alert.feature` and the optional `partnerFundsTransfer`
already declared in `saasquatch.d.ts`

### Removed

- \<sqm-tax-and-cash>
- Removed `dashboard_noFormNeededSubtext`, which has had no effect since 1.15.0 when
`noFormNeededSubtext` was removed from \<sqm-tax-and-cash-dashboard>

## [1.15.7] - 2025-11-3

### Changed

- \<sqm-referred-registration>
- Changed the default text for `registerLabel` to "Choose Your Reward"
- Changed the default text for `registerLabel` to "Claim Your Reward"

## [1.15.6] - 2025-10-28

Expand Down
14 changes: 0 additions & 14 deletions packages/mint-components/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4794,13 +4794,6 @@ export namespace Components {
* @uiGroup Dashboard Properties
*/
"dashboard_newFormButton": string;
/**
* No other statuses or badges will be displayed in the tax form section in this case.
* @uiName Tax form not required text
* @uiGroup Dashboard Properties
* @uiWidget textArea
*/
"dashboard_noFormNeededSubtext": string;
/**
* @uiName Not registered for indirect tax text
* @uiGroup Dashboard Properties
Expand Down Expand Up @@ -11903,13 +11896,6 @@ declare namespace LocalJSX {
* @uiGroup Dashboard Properties
*/
"dashboard_newFormButton"?: string;
/**
* No other statuses or badges will be displayed in the tax form section in this case.
* @uiName Tax form not required text
* @uiGroup Dashboard Properties
* @uiWidget textArea
*/
"dashboard_noFormNeededSubtext"?: string;
/**
* @uiName Not registered for indirect tax text
* @uiGroup Dashboard Properties
Expand Down
4 changes: 2 additions & 2 deletions ...es/mint-components/src/components/tax-and-cash/sqm-payout-status-alert/usePayoutStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ export function getStatus(data: UserQuery): PayoutStatus {

const hasTransferredReward = data?.user?.rewards?.data?.find(
(reward) =>
reward.statuses.includes("REDEEMED") &&
reward.partnerFundsTransfer.status === "TRANSFERRED"
reward.statuses?.includes("REDEEMED") &&
reward.partnerFundsTransfer?.status === "TRANSFERRED"
);

if (!data.user?.impactConnection?.connected || !account)
Expand Down
7 changes: 4 additions & 3 deletions packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,14 @@ export type UserQuery = {
customFields?: {
[key: string]: any;
};
rewards: {
rewards?: {
data: {
statuses: string[];
partnerFundsTransfer: {
// Rewards that never resulted in a payout have no funds transfer
partnerFundsTransfer?: {
id: string;
status: string;
};
} | null;
}[];
};
managedIdentity?: {
Expand Down
1 change: 0 additions & 1 deletion packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
| `dashboard_invoiceMoreLabel` | `dashboard_invoice-more-label` | | `string` | `"Next"` |
| `dashboard_invoicePrevLabel` | `dashboard_invoice-prev-label` | | `string` | `"Prev"` |
| `dashboard_newFormButton` | `dashboard_new-form-button` | | `string` | `"Submit new form"` |
| `dashboard_noFormNeededSubtext` | `dashboard_no-form-needed-subtext` | No other statuses or badges will be displayed in the tax form section in this case. | `string` | `"Tax documents are only required if you are based in the US or joining the referral program of a US based brand."` |
| `dashboard_notRegisteredForTax` | `dashboard_not-registered-for-tax` | | `string` | `"Not registered for indirect tax. If you’ve previously registered with your tax authority, contact our {supportLink} to add your information to stay tax compliant."` |
| `dashboard_payoutFromImpact` | `dashboard_payout-from-impact` | Displayed under the payout details card. | `string` | `"Your balance may take up to 24 hours to update. Payouts will be sent from our referral program provider, impact.com."` |
| `dashboard_payoutHoldAlertDescription` | `dashboard_payout-hold-alert-description` | Part of the alert displayed at the top of the page when there’s been an issue preventing payouts. | `string` | `"Please contact our {supportLink} or check your inbox for an email from our referral program provider, impact.com."` |
Expand Down
9 changes: 0 additions & 9 deletions packages/mint-components/src/components/tax-and-cash/sqm-tax-and-cash/sqm-tax-and-cash.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,15 +761,6 @@ export class TaxAndCashMonolith {
*/
@Prop() dashboard_taxDocumentSectionSubHeader: string =
"{documentType} tax form";
/**
* No other statuses or badges will be displayed in the tax form section in this case.
*
* @uiName Tax form not required text
* @uiGroup Dashboard Properties
* @uiWidget textArea
*/
@Prop() dashboard_noFormNeededSubtext: string =
"Tax documents are only required if you are based in the US or joining the referral program of a US based brand.";
/**
*
* @uiName Indirect tax section header
Expand Down
Loading