Add successSegments and failureSegments to form type - #517
Open
ian hitchcock (ianhitchcock) wants to merge 2 commits into
Open
Add successSegments and failureSegments to form type#517ian hitchcock (ianhitchcock) wants to merge 2 commits into
ian hitchcock (ianhitchcock) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
ian hitchcock (ianhitchcock)
August 7, 2026 18:31
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds successSegments and failureSegments to the FormRequestContext form payload type so integrations can access these segment keys during form handling (notably for registration submit flows where success segments should propagate into downstream processing like webhooks).
Changes:
- Extend
FormRequestContext.formwith optionalsuccessSegments?: string[] - Extend
FormRequestContext.formwith optionalfailureSegments?: string[]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit was generated by GitHub Actions CI
Copilot started reviewing on behalf of
ian hitchcock (ianhitchcock)
August 7, 2026 19:18
View session
Copilot stopped reviewing on behalf of
ian hitchcock (ianhitchcock) due to an error
August 7, 2026 19:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Add successSegments and failureSegments to form type. This is needed for managed identity service to handle successSegments on the registration form submit. The default registration form template ships with a success segment, that currently does not show up in the user.created webhook, this changes that.
Type of change
Links
Checklists
Development
Paperwork
Code review