Skip to content

Add successSegments and failureSegments to form type - #517

Open
ian hitchcock (ianhitchcock) wants to merge 2 commits into
masterfrom
mis-successSegments
Open

Add successSegments and failureSegments to form type#517
ian hitchcock (ianhitchcock) wants to merge 2 commits into
masterfrom
mis-successSegments

Conversation

@ianhitchcock

Copy link
Copy Markdown
Contributor

Description of the change

Add successSegments and failureSegments to form type. This is needed for managed identity service to handle successSegments on the registration form submit. The default registration form template ships with a success segment, that currently does not show up in the user.created webhook, this changes that.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI lite review requested due to automatic review settings August 7, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds successSegments and failureSegments to the FormRequestContext form payload type so integrations can access these segment keys during form handling (notably for registration submit flows where success segments should propagate into downstream processing like webhooks).

Changes:

  • Extend FormRequestContext.form with optional successSegments?: string[]
  • Extend FormRequestContext.form with optional failureSegments?: string[]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This commit was generated by GitHub Actions CI
Copilot AI review requested due to automatic review settings August 7, 2026 19:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants