Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-targets.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build Code Editor Targets
name: Build Code Editor Targets11
on:
push:
branches:
Expand Down Expand Up @@ -98,4 +98,4 @@ jobs:
--namespace "GitHub/Workflows" \
--metric-name "ExecutionsFailed" \
--dimensions "Repository=${{ env.REPOSITORY }},Workflow=BuildTargets" \
--value 1
--value 1
16 changes: 12 additions & 4 deletions .github/workflows/security-scan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:
with:
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
aws-region: us-east-1
role-session-name: security-scan-${{ matrix.target }}-${{matrix.branch}}
role-session-name: scan-${{ matrix.target }}-${{matrix.branch}}

- name: Publish Scan Invoked metric
run: |
Expand All @@ -248,8 +248,14 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
# For fork-origin PRs, we can't directly use matrix.branch as the branch does not exist in the
# Code Editor repo. The branch only exists in the fork.
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || matrix.branch }}
submodules: recursive

- name: Make sure code changes from PR branch are present
run: |
ls -l

- name: Update security scan script from main
run: |
Expand Down Expand Up @@ -440,7 +446,7 @@ jobs:
with:
role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
aws-region: us-east-1
role-session-name: security-scan-global-dependencies-${{matrix.branch}}
role-session-name: scan-global-dependencies-${{matrix.branch}}

- name: Publish Scan Invoked metric
run: |
Expand All @@ -453,7 +459,9 @@ jobs:
- name: Checkout branch
uses: actions/checkout@v4
with:
ref: ${{ matrix.branch }}
# For fork-origin PRs, we can't directly use matrix.branch as the branch does not exist in the
# Code Editor repo. The branch only exists in the fork.
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || matrix.branch }}
submodules: recursive

- name: Update security scan script from main
Expand Down
1 change: 1 addition & 0 deletions test-file.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hi there!