feat(docker): update base container to v26 - #138
Merged
Conversation
Up to standards ✅🟢 Issues
|
The node:26 images no longer bundle yarn, so the install layer exited 127 on `yarn: not found` and the image would not build at all. I swapped it for `npm install --omit=dev`, using the npm 11.19.0 that already ships in the base. `yarn check` and `yarn autoclean` came out with it. Neither has an npm equivalent, and there is no lock file under app/ for a check to verify against. `npm cache clean --force` does what autoclean did for the layer size.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Application node-webserver-67ec474-138-pr-reviews has been created. |
1 similar comment
|
Application node-webserver-67ec474-138-pr-reviews has been created. |
|
Application node-webserver-67ec474-138-pr-reviews is now running new version of deployments manifests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The image now builds on
node:26-alpine3.24and runs Node 26.8.1. EveryENVmoves to theKEY=valueform and the oldmaintainerlabel gives way to the OCI authors, title and description annotations, which takesdocker build --checkfrom six warnings down to one. The build script moves out of the repository root intoscripts/.Related Issues
Fixes #139.
Changes Made
The
node:26images no longer bundle yarn, so the install layer died onyarn: not foundbefore anything else could run. Dependencies install withnpm install --omit=devinstead, against the npm 11.19.0 that ships in the base. That also removedyarn checkandyarn autoclean, neither of which has an npm equivalent, andnpm cache clean --forcekeeps the layer size where autoclean left it.The one remaining lint warning is
JSONArgsRecommendedonCMD. Switching to the JSON form there would stop the shell expanding${PORT}, so it stays as it is.Testing
docker build- image builds, 100 packages installeddocker runthencurl /healthz- HTTP 200,{"status":"healthy"}curl /- returns the build ID passed through--build-argdocker exec ... id -un- runs asnobodydocker build --check- 1 warning, down from 6 on mainChecklist
build.shpath