fix: Resolve React unique key warning in Exercises list#757
Conversation
- Added a deterministic `id` field to the `Exercise` interface in `contentLoader.ts`. - Updated `src/pages/Exercises.tsx` to use `exercise.id` instead of array index as the React `key`. - Updated mock test data in `Exercises.test.tsx` and `ExerciseCard.test.tsx` to include the `id` field. - This resolves the React console warning: `Each child in a list should have a unique "key" prop`. Co-authored-by: saint2706 <45678566+saint2706@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Resolves a React unique key warning when rendering the list of Exercises.
The previous implementation relied on the array index for React
keys when renderingExerciseCardcomponents, leading to potential rendering issues and a React warning in strict mode.Changes:
idstring property (derived from theslugor title) to theExerciseinterface.Exercises.tsxto use this newidfield.PR created automatically by Jules for task 14789836966859749682 started by @saint2706