Fix popup dismissal on Omarchy 4.0.3 - #4
Open
lutfi-zain wants to merge 1 commit into
Open
Conversation
Omarchy 4.0.3 made bar.centerHoverRevealSuppressed a read-only property on PluginBarApi and added a bar.setCenterHoverRevealSuppressed() setter method. Directly assigning to the property now throws a TypeError, which aborts open() and close() before reaching controller.show() / hide(), leaving the fullscreen layer-shell overlay trapped and unable to collapse. Prefer the setter method and keep property assignment as a fallback for older shells, matching the first-party clock and weather panels.
|
nice, needed this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Omarchy 4.0.3, clicking the OmaPrayers bar widget causes the desktop to freeze: once opened, the panel cannot be collapsed or dismissed (clicking outside or pressing Escape does nothing), and all desktop click interactions are trapped by the fullscreen layer-shell overlay.
Cause
Omarchy 4.0.3 changed the third-party plugin interface (
PluginBarApi) by turningbar.centerHoverRevealSuppressedinto areadonly propertyand introducing the setter methodbar.setCenterHoverRevealSuppressed(value).In
Panel.qml:Directly assigning to
root.bar.centerHoverRevealSuppressedthrowsTypeError: Cannot assign to read-only property "centerHoverRevealSuppressed". Whenclose()runs:The unhandled exception aborts execution before
root.controller.hide()is called, leaving the overlay active and capturing all cursor/pointer events across the screen.Solution
Prefer calling
root.bar.setCenterHoverRevealSuppressed(value)when available, and fall back to the direct property assignment on older Omarchy shells, matching the first-partyclockandweatherpanels in Omarchy Quattro:Verification
omarchy plugin validate .passed.tests/runpassed (all 12 engine scenarios, 54 model scenarios, AlAdhan snapshot tests, and engine QML parity tests).