Update the Portal component to use the new react portal api (when overflowBoundaryElement is used for position)#3029
Open
bolivierjr wants to merge 4 commits intosalesforce:masterfrom
Open
Conversation
…ntainer to React.createPortal, so that the context from PortalSettings, carries through when having multiple layers.
…s when it's not a portalMount and using the actual react portals so it does not have breaking changes if someone is using these props.
…Container so the id, classNames and styles get into the portalNode before updating the state for portalContainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Portal component by switching from ReactDOM.unstable_renderSubtreeIntoContainer to React.createPortal, so that the context from PortalSettings, carries through when having multiple layers of overflowBoundaryElement.
This would also get you one step closer to using react 18 in the future, since the ReactDOM unstable_renderSubtreeIntoContainer method will be deprecated and will need to change to the react portals api.
Fixes #3028
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.