fix type mismatch, convert tabIndex string to number base 10#3112
fix type mismatch, convert tabIndex string to number base 10#3112mjaiswal-sfdc wants to merge 3 commits intosalesforce:masterfrom
Conversation
|
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
|
Thanks for the contribution! It looks like @mjaiswal-sfdc is an internal user so signing the CLA is not required. However, we need to confirm this. |
|
@interactivellama can you review this MR , this is the correct repo . Thanks! |
|
Thank you for the contribution! Could you send me a small demo on internal Slack on the issue this is fixing? I'm curious to know why a number passed to a JSX HTML attributes that eventually is a string in HTML needs to be a number. Is DataTable passing in the wrong type? Feel free to re-iterate the existing component documentation to me. |
Fixes #
checkbox/index.js has tabIndex which is number but is assigned value props.tabIndex which is type string. This issue is potentially causing issue with checkbox focus in other projects where this module is consumed.
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.