@W-15246641 : fix for Disappearing tooltip button content#3171
Open
bdewangan wants to merge 6 commits intosalesforce:masterfrom
Open
@W-15246641 : fix for Disappearing tooltip button content#3171bdewangan wants to merge 6 commits intosalesforce:masterfrom
bdewangan wants to merge 6 commits intosalesforce:masterfrom
Conversation
Contributor
|
@bdewangan could you add a description to summarize your fix. A screenshot or recording could also be helpful |
Contributor
|
Based on the logic you implemented, it seems like you are trying to do here is: when the mouse is outside of the tooltip element or if it is not in hover state, we close the tooltip. I think a better way to address it is to making. tooltips persistent after triggering until explicitly dismissed. With this, we also need to provide a clear way to dismiss the tooltip (ESC key or click outside, or has a close icon) |
Contributor
Author
|
we have made changes to make it stay when hovered over the tooltip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fixhas been run and linting passes.components/component-docs.jsonCI tests pass (npm test).REVIEWER checklist (do not remove)
components/component-docs.jsontests.Required only if there are markup / UX changes
last-slds-markup-reviewinpackage.jsonand push.last-accessibility-review, topackage.jsonand push.npm run local-updatewithin locally cloned site repo to confirm the site will function correctly at the next release.