feat(Storage) : Implement Object Contexts with filter and validation by salilg-eng · Pull Request #2 · salilg-eng/google-cloud-php

salilg-eng · 2026-04-14T06:35:30Z

Implemented validateContexts() to enforce strict type checks. It now throws InvalidArgumentException if custom contexts are not arrays or if values do not follow alphanumeric naming constraints (no double quotes or forward slashes
Ensured logic validating context structures before initiating API requests.
Add comprehensive unit and system tests covering CRUD, server-side
operations, and complex filtering scenarios.

salilg-eng · 2026-04-14T12:52:52Z

/Gemini review

gemini-code-assist

Code Review

This pull request introduces support for object contexts in Cloud Storage, enabling the attachment of key-payload pairs to objects for identification and filtering. The changes include updates to the service definition, connection handling, and the addition of validation logic for custom contexts. Feedback highlights the need for consistent validation across all object modification methods—such as update, copy, and rewrite—and suggests refining validation regex and error messages. Additionally, corrections were requested for a misleading internal comment and the incorrect placement of contexts within a unit test's metadata array.

gemini-code-assist · 2026-04-14T12:55:02Z

+            // during object creation context properties go into metadata
+            // but not into request body


This comment is misleading. In the Cloud Storage JSON API, contexts is a property of the Object resource. When calling insertObject, the metadata provided in $args['metadata'] represents the object resource and constitutes the request body. Thus, it is indeed part of the request body.

// during object creation context properties are part of the object resource // and should be included in the request body.

thiyaguk09

Could you please add the missing tests?

thiyaguk09 · 2026-04-16T03:33:22Z

@@ -215,12 +217,284 @@ public function testObjectRetentionUnlockedMode()
        $this->assertFalse($object->exists());
    }

-    public function testObjectExists()


Do not remove the existing test testObjectExists.

That was my bad I added

thiyaguk09 · 2026-04-16T05:33:01Z

-        $this->assertFalse($object->exists());
+    }
+
+    public function testGetContextAndServerGenratedTimes()


Replaced with this testGetContextsWithServerTime

thiyaguk09 · 2026-04-16T05:33:19Z

+    {
+        $initialContexts = [
+            'custom' => [
+                'tag' => ['value' => 'orignal'],


thiyaguk09 · 2026-04-16T05:33:31Z

+        $inherited = $object->rewrite(self::$bucket, ['name' => 'inherit-' . uniqid()]);
+        $info = $inherited->info();
+
+        $this->assertEquals('orignal', $info['contexts']['custom']['tag']['value']);


thiyaguk09 · 2026-04-16T05:35:59Z

+            ],
+        ];
+
+        $object = $this->createObjectWithContexts($initialContexts);


Ensure the object has context first.

Yes, I ensure that and according to added

thiyaguk09 · 2026-04-16T06:10:47Z

-
+    const CONTEXT_OBJECT_KEY = 'insert-key';
+    const CONTEXT_OBJECT_VALUE = 'insert-val';
+    const CONTEXT_OBJECT_PREFIX = 'object-contexts-';


nits: If this is not being reused, go with a static value, similar to how it is added in other tests.

Removed this constant and directly used static

thiyaguk09 · 2026-04-16T06:20:02Z

+        }
+    }
+
+    public function removeAndClearAllContextsDataProvider()


These scenarios are fundamentally wrong; you are performing the same operation twice with the same key.

I can remove the expected value from dataProvider and compare directly in the method testRemoveAndClearAllObjectContexts.

thiyaguk09 · 2026-04-16T06:24:24Z

+        );
+    }
+
+    public function testGetFiltersByPresenceOfKeyValuePair()


Which is a list operation? Why is it named "get" here? Please correct this.

thiyaguk09 · 2026-04-16T06:26:07Z

+        $iterator = $bucket->objects([
+            'filter' => $filter
+        ]);
+        $iterator->current();


Schemes test without assert!

thiyaguk09 · 2026-04-16T06:28:59Z

+            'metadata' => [
+                'contexts' => [
+                    'custom' => [
+                        'dept' => ['value' => 'eng', 'createTime' => '...']


Use DateProvider instead of '...', and include all values in the get method since the update time is currently missing.

salilg-eng · 2026-04-17T05:51:35Z

/Gemini review

gemini-code-assist

Code Review

This pull request introduces support for object contexts in Google Cloud Storage, enabling users to attach and filter by key-payload pairs. The implementation includes metadata handling in the REST connection, validation logic for context keys and values during upload, and updates to the service definition for context-based filtering. Extensive unit and system tests were added to verify CRUD operations and filtering. Feedback suggests refactoring the validation logic into a shared trait to ensure consistency across other operations like update and copy, and improving the granularity of error messages for context value validation.

gemini-code-assist · 2026-04-17T05:53:36Z

+            if ($val !== '' && !preg_match('/^[a-zA-Z0-9][^"\/]*$/', $val)) {
+                throw new \InvalidArgumentException('Object context value must start with an alphanumeric.');
+            }


For consistency with the key validation logic and to provide more specific error messages, consider splitting the value validation into separate checks. The current error message is also incomplete as it doesn't mention the restrictions on double quotes and forward slashes.

if ($val !== '') { if (!preg_match('/^[a-zA-Z0-9]/', $val)) { throw new \InvalidArgumentException('Object context value must start with an alphanumeric.'); } if (preg_match('/["\/]/', $val)) { throw new \InvalidArgumentException('Object context value cannot contain double quotes or forward slashes.'); } }

salilg-eng · 2026-04-17T05:59:04Z

/Gemini review

gemini-code-assist

Code Review

This pull request introduces support for object contexts in Google Cloud Storage, enabling users to attach, update, and filter objects based on custom key-value pairs. The changes span the service definition, REST connection handling, and core library classes, accompanied by extensive system and unit tests. Feedback focuses on improving the reusability of validation logic across different object operations, ensuring that null values are correctly handled to allow clearing contexts, and refining error messages and documentation for better consistency and accuracy.

gemini-code-assist · 2026-04-17T06:01:13Z

+            if ($val !== '' && !preg_match('/^[a-zA-Z0-9][^"\/]*$/', $val)) {
+                throw new \InvalidArgumentException('Object context value must start with an alphanumeric.');
+            }


The error message is misleading. If the value starts with an alphanumeric character but contains a forward slash or a double quote, the regex will fail, but the exception message will only mention the alphanumeric requirement. It should be updated to reflect all constraints.

if ($val !== '' && !preg_match('/^[a-zA-Z0-9][^"\/]*$/', $val)) { throw new \InvalidArgumentException('Object context value must start with an alphanumeric and cannot contain double quotes or forward slashes.'); }

gemini-code-assist · 2026-04-17T06:01:13Z

+     *     @type string $contexts.custom.{key}.value The value associated with the context.
+     *           Must start with an alphanumeric character and cannot contain double quotes (`"`)
+     *           or forward slashes (`/`).


The documentation for the context value here is inconsistent with the one in Bucket.php. It is missing the 'If not empty' qualifier, which is important because the validation logic allows empty strings.

* @type string $contexts.custom.{key}.value The value associated with the context. * If not empty, must start with an alphanumeric character and cannot contain double quotes (`"`) * or forward slashes (`/`).

salilg-eng added 30 commits March 20, 2026 13:27

insert and get contexts perform

c2a16fb

Unit Test Cases

b941e81

Unit Test Cases

fa985a8

Resolve comments

409e321

Follow the checklist and resolved comments

8f5051f

Follow the checklist and resolved comments

49d60ad

Follow the checklist and resolved comments

59732ed

Fixed gemini related comments

ffc8b00

Fixed gemini related comments

fbf594e

Style code

37b7051

Style code

e94a00d

Personal Review code

a563bb4

Style set

d258bd9

Style set

711c118

Required Changes

d70d66a

Required Changes

41aec81

Required Changes

1e86369

As per new comments changes

3520f8b

Changes

7e433b8

Remove old test method

248ffe8

Handled System Test cases

fdd1e97

Gemini review and style check

902eb86

Style Check

e87efaf

Style Check

e78441d

Pending scenario covers

5bb84fb

Pending scenario covers

f31760e

Pending scenario covers

d1fb39c

Pending scenario covers

eda39e8

Pending scenario covers

be06d29

Remove unwanted delete code

64b6c01

gemini review

c4021cb

gemini-code-assist bot reviewed Apr 14, 2026

View reviewed changes

Repository owner deleted a comment from gemini-code-assist bot Apr 14, 2026

salilg-eng marked this pull request as ready for review April 14, 2026 18:17

salilg-eng self-assigned this Apr 14, 2026

gemini review

8eaf4de

salilg-eng requested review from gurusai-voleti and thiyaguk09 April 14, 2026 18:29

thiyaguk09 requested changes Apr 16, 2026

View reviewed changes

salilg-eng added 5 commits April 17, 2026 02:52

Changed according to feedback

51d3e09

Final changes code

a8a67ff

Final changes code

fa23edb

Final changes code

99065d2

Final change and push

b30316a

gemini-code-assist bot reviewed Apr 17, 2026

View reviewed changes

Repository owner deleted a comment from gemini-code-assist bot Apr 17, 2026

gemini-code-assist bot reviewed Apr 17, 2026

View reviewed changes

salilg-eng requested a review from thiyaguk09 April 17, 2026 06:06

thiyaguk09 approved these changes Apr 17, 2026

View reviewed changes

Repository owner deleted a comment from gemini-code-assist bot Apr 17, 2026

Final change and push

bd9c720

salilg-eng requested a review from thiyaguk09 April 17, 2026 08:19

		// during object creation context properties go into metadata
		// but not into request body

Conversation

salilg-eng commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

salilg-eng commented Apr 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

thiyaguk09 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

salilg-eng commented Apr 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

salilg-eng commented Apr 17, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

salilg-eng commented Apr 14, 2026 •

edited

Loading