fix(acp): enforce authentication discriminator boundaries - #184
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 8, 2026
Default only an absent v1 type to agent, reject non-string discriminators, and preserve unsupported strings and payload fields. Share version-aware authentication serialization across DTO, collection, and initialize roots so unknown fields cannot override the negotiated method identity. Add raw initialize transport regressions, presentation selection coverage, and schema round-trip properties. Validation: 593 SDK tests, 26 presentation authentication tests, analyzer and package validation, external nupkg consumer, and a 9-case failing whitelist mutation. Refs #147
YoungSx
force-pushed
the
fix/acp-auth-discriminator-boundaries
branch
from
September 10, 2026 10:00
4de1fbc to
9219430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
鉴权列表中空白或未知
type不能获得默认 agent 的执行资格；只有缺省或精确agent可发送 authenticate。单项类型错误仍被拒绝，initialize.authMethods 按官方 schema 跳过坏项并保留其余合法登录方式，列表本身类型错误时取空列表。所有根使用同一版本化源生成转换：v1 id / v2 methodId，未知扩展载荷保留。补充原始 initialize → 真实 transport 出网断言；单项严格解析、未知值往返及 v2 必填判别独立验证。共享指标测试按 trace 隔离，避免并行用例串扰。
验证：
4a4e3c53；独立 Standards 与 Spec 复审通过父列表修正。9219430c的完整 CI 16 项成功、1 项原有条件跳过；已 rebase merge，main 合并提交ceb25cff。Refs #147。终端交互登录及独立 Agent 验收属于后续工作，本 PR 不关闭总单。依据 ACP schema 的 authMethods default-on-error / skip-invalid-items（上游
367c56fb6115f391bc7550288363f87416cd0af8）。