Skip to content

Fix migration using wrong config key for database connection #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
craigpotter wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −1
Open

Fix migration using wrong config key for database connection #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion database/migrations/create_barstools_table.php.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ return new class extends Migration
*/
public function getConnection(): string|null
{
return config('barstool.database_connection');
return config('barstool.connection') ?? config('barstool.database_connection');
}

/**
Expand Down
18 changes: 18 additions & 0 deletions tests/BarstoolTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,24 @@
expect(Barstool::make()->getConnectionName())->toBe('sqlite');
});

it('uses the correct config key for the migration database connection', function () {
$migration = include __DIR__.'/../database/migrations/create_barstools_table.php.stub';

// The migration should use the 'barstool.connection' config key
config()->set('barstool.connection', 'pgsql');
expect($migration->getConnection())->toBe('pgsql');

// It should fall back to 'barstool.database_connection' for backwards compatibility
config()->set('barstool.connection', null);
config()->set('barstool.database_connection', 'sqlite');
expect($migration->getConnection())->toBe('sqlite');

// 'barstool.connection' takes priority over 'barstool.database_connection'
config()->set('barstool.connection', 'mysql');
config()->set('barstool.database_connection', 'sqlite');
expect($migration->getConnection())->toBe('mysql');
});

it('can change the number of days to keep recordings for', function () {
// Check the default value is 30
expect(config('barstool.keep_for_days'))->toBe(30);
Expand Down