[master] Fix insertion of a line with special characters#65155
Closed
berkut-174 wants to merge 0 commit intosaltstack:masterfrom
Closed
[master] Fix insertion of a line with special characters#65155berkut-174 wants to merge 0 commit intosaltstack:masterfrom
berkut-174 wants to merge 0 commit intosaltstack:masterfrom
Conversation
Contributor
|
This will need to be very thoroughly tested. Historically, any changes to the file module are prone to introduce unforseen bugs. |
Contributor
|
This will also need a changelog and some tests. |
Contributor
|
@berkut-174 Nice change. The code change looks correct. Can you add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the insertion of a line into a file when a state like this is used:
Previous Behavior
New Behavior