Widen SCM service-deletion wait budgets in NSIS stress tests - #70239
Open
twangboy wants to merge 1 commit into
Open
Widen SCM service-deletion wait budgets in NSIS stress tests#70239twangboy wants to merge 1 commit into
twangboy wants to merge 1 commit into
Conversation
CreateService for salt-minion can race the SCM's async cleanup after a prior uninstall's SimpleSC::RemoveService, since the SCM doesn't purge the service registry key until every handle is closed. The existing 15s wait / 20s CreateService retry budget was too tight: PR saltstack#70238 stress run 33911838747 (iteration 88) showed this window climbing past 35s under load before exhausting the retries and aborting. - Raise the install-side pending-deletion wait and the uninstall-side post-removal wait from 15s to 60s (30->120 polls at 500ms) in Salt-Minion-Setup.nsi. - Raise the CreateService retry loop from 10 to 20 attempts (2s apart, 40s total). - Raise SCM_WAIT_SECS in conftest.py's clean_env() from 15s to 60s to match. - Log elapsed wait time on the success path (not just on timeout) in all three wait loops, so future stress-test logs show the SCM latency trend across iterations instead of only surfacing it once a run blows the budget and fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CreateService for salt-minion can race the SCM's async cleanup after a prior uninstall's SimpleSC::RemoveService, since the SCM doesn't purge the service registry key until every handle is closed. The existing 15s wait / 20s CreateService retry budget was too tight: PR #70238 stress run 33911838747 (iteration 88) showed this window climbing past 35s under load before exhausting the retries and aborting.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes