Develop - Connectivity improvements, Copy adb logs, Native mirroring, keyboard navigation for file browser and translations#226
Merged
Conversation
Fixes the issue #207
Test: Just reconnect with android, it won't disconnect automatically after a few seconds. [Which was irritating TBH]
FIXUP: Fix Menubar is not focused by default when opening
feat: Add a notification silence button in menu bar
fixup: Improve the auto connect and timeout
…o ScrcpyMirrorView
…oll gestures in MetalVideoView
Mirror - Initial implementation
…w with updated AppState synchronization
New Crowdin updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and fixes across the project, focusing on notification management, device discovery robustness, UI improvements, and some project configuration updates. The most significant changes include the addition of a global "silence all notifications" feature, improvements to device discovery handling during network transitions, and better UI feedback for ongoing operations.
Notification Management Improvements:
silenceAllNotificationsproperty toAppState, allowing users to silence all notifications. When enabled, all delivered and pending notifications are cleared, and new notifications are suppressed. This preference is persisted inUserDefaults. [1] [2] [3] [4]silenceAllNotificationsbefore displaying. [1] [2]Device Discovery and Connectivity:
QuickConnectManager, added aconnectingDeviceIDproperty to track the device currently being connected to, and updated the UI accordingly during connection attempts. [1] [2]UI/UX Enhancements:
GlassButtonViewnow supports anisLoadingstate, showing aProgressViewspinner when active. [1] [2]App State and Persistence:
isNativeMirroringproperty toAppStateand reset its value on launch to prevent unwanted auto-opening. [1] [2]Project Configuration Updates:
scrcpy-server-v3.3.4file to the Xcode project resources.26and marketing version to3.1.0. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Other:
WindowAccessorhelper fromAppDelegate.swift.Let me know if you want a deeper dive into any of these changes!