Change delist schedule API request to unsigned#1659
Change delist schedule API request to unsigned#1659carlosmiei merged 1 commit intosammchardy:masterfrom
Conversation
It's not necessary to sign the spot delist schedule request.
| async def get_spot_delist_schedule(self, **params): | ||
| return await self._request_margin_api( | ||
| "get", "/spot/delist-schedule", signed=True, data=params | ||
| "get", "/spot/delist-schedule", signed=False, data=params |
There was a problem hiding this comment.
@m-HD Hello, if you try to open the link in the browser https://api.binance.com/sapi/v1/spot/delist-schedule
you can see you get {"code":-2014,"msg":"API-key format invalid."} meaning that the endpoint indeed requires credentials
There was a problem hiding this comment.
For spot delist schedule an API-key is necessary, that's true. But the request for this endpoint doesn't need to be signed as it is MARKET_DATA.
See: https://developers.binance.com/docs/wallet/general-info#request-security
I have tested the patch and it worked.
There was a problem hiding this comment.
This pull request is still open. It's working properly, but hasn't been included in the latest update 1.0.35.
What's the problem?
There was a problem hiding this comment.
@m-HD Sorry I was assuming that providing signed=False would skip the APIKey in Headers (since this endpoint is an "hybrid" only requires apiKey but not signing) but that's not the case, will merge it now.
2 participants
It's not necessary to sign the spot delist schedule request.