opam: bump cascade pin to the resolve_theme fixes#95
Open
samoht wants to merge 2 commits into
Open
Conversation
Points at cascade main (47612cf7), which carries the color-mix component-order, unrelated-@property-retention, and nested-fallback resolve_theme fixes that the filter and transition parity cases need.
samoht
changed the title
cascade renamed the diff CLI flag from --diff=semantic to --diff=canonical; the pinned cascade (47612cf7) no longer accepts the old spelling, so the example parity checks and bench script must use the new name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the pin at cascade main (
47612cf7), which carries the resolve_theme fixes the parity suite needs: color-mix component order (#140), unrelated-@propertyretention (#142), nested-fallback inlining (#138), and@propertyorder (#141). With this cascade, tw's full suite passes — the filter (553) and transition (560) cases are green.The pin bump and the examples change are coupled: cascade renamed its
diffCLI flag--diff=semantic->--diff=canonical, and the new cascade rejects the old spelling, so the example parity checks and the bench script move to the new name in lockstep.Merging this turns main green; #81 and #96 then go green on rebase.