fix(cli): stop interactive prompts hanging behind the status spinner#96
Merged
Conversation
install, uninstall, and refresh held a clack spinner across the whole run; its redraw timer overwrote the interactive prompts underneath (skill-pack select, broken-link, invalid-resource confirm, uninstall drift, and the refresh consent prompt), so the command waited on invisible stdin — refresh silently timed out after 5 minutes and skipped the pack. Skip the spinner whenever a run may prompt (real TTY, no --force/--dry-run) via a shared mayPrompt() gate, mirroring init. Also harden the prompt primitives: - confirm() now delegates to the shared readLine helper, so a closed or erroring stdin declines gracefully instead of hanging on Ctrl-D or crashing. - readLine() resolves to '' (decline) on a stream error instead of throwing. - install --force --dry-run now previews the same resource set a real --force install writes (invalid resources were wrongly dropped from the preview). Tests: refresh spinner-gating, confirm() EOF/error via readLine, readLine stream-error, and pool-resolution force+dry-run precedence.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install, uninstall, and refresh held a clack spinner across the whole run; its redraw timer overwrote the interactive prompts underneath (skill-pack select, broken-link, invalid-resource confirm, uninstall drift, and the refresh consent prompt), so the command waited on invisible stdin — refresh silently timed out after 5 minutes and skipped the pack. Skip the spinner whenever a run may prompt (real TTY, no --force/--dry-run) via a shared mayPrompt() gate, mirroring init.
Also harden the prompt primitives:
Tests: refresh spinner-gating, confirm() EOF/error via readLine, readLine stream-error, and pool-resolution force+dry-run precedence.
What does this PR do?
Type of change
Checklist
pnpm test,pnpm lint,pnpm typecheck)pnpm changeset) for user-visible changes