Substituted Meetup buttons#27
Open
catb0y wants to merge 1 commit intosamrocksc:masterfrom
catb0y:minor-fix-index
Open
Substituted Meetup buttons#27catb0y wants to merge 1 commit intosamrocksc:masterfrom catb0y:minor-fix-index
catb0y wants to merge 1 commit intosamrocksc:masterfrom
catb0y:minor-fix-index
Conversation
samrocksc
reviewed
Oct 25, 2017
| <a href="https://www.meetup.com/Coffee-and-Code-East-Valley/" class="mdl-button mdl-button--colored mdl-js-button mdl-js-ripple-effect"> | ||
| View Meetup | ||
| </a> | ||
| <a href="https://www.meetup.com/Coffee-and-Code-East-Valley/"><img src="images/if_meetup_2363057.png"></a> |
Owner
There was a problem hiding this comment.
Looks like the ripple effect is removed from this, and it also will not match the styling of its fellow components.
samrocksc
requested changes
Oct 25, 2017
Owner
samrocksc
left a comment
There was a problem hiding this comment.
We would want to keep all the icons along the same styling in order to make this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.