Add overflow check in bgzf_index_load_hfile() #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function reads an item count from the input file and uses it to allocate an array of file offsets. It's possible for this to overflow, resulting in an attempt to malloc(0) and, if that returns a valid pointer, an attempt to zero 16 bytes in a zero-length allocation. Fix by checking that the allocation will not overflow. Thanks to Harrison Green for reporting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function reads an item count from the input file and uses it to allocate an array of file offsets. It's possible for this to overflow, resulting in an attempt to malloc(0) and, if that returns a valid pointer, an attempt to zero 16 bytes in a zero-length allocation.
Fix by checking that the allocation will not overflow.
Thanks to Harrison Green for reporting this.