Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Claude finished @binoy14's task in 2m 51s —— View job Review
Docs-only PR ( No issues found. The README content is accurate against the implementation:
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (44a7ed9) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 10.94 MB | - |
| Bundled (gzip) | 2.05 MB | - |
| Import time | 847ms | +13ms, +1.6% |
bin:sanity
| Metric | Value | vs main (44a7ed9) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.84 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 2.02s | +27ms, +1.4% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (44a7ed9b)
| Metric | Value | vs main (44a7ed9) |
|---|---|---|
| Internal (raw) | 93.1 KB | - |
| Internal (gzip) | 21.9 KB | - |
| Bundled (raw) | 21.60 MB | - |
| Bundled (gzip) | 3.42 MB | - |
| Import time | 799ms | -9ms, -1.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (44a7ed9b)
| Metric | Value | vs main (44a7ed9) |
|---|---|---|
| Internal (raw) | 976 B | - |
| Internal (gzip) | 507 B | - |
| Bundled (raw) | 50.7 KB | - |
| Bundled (gzip) | 12.6 KB | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a comprehensive
packages/@sanity/cli-e2e/README.mdcovering setup,globalSetup, therunCli()API (both spawn and PTY modes), CI workflows, debugging, and gotchas — none of which were documented before. Slims thewriting-cli-e2e-testsskill to focus on test-writing patterns and cross-references the README for infrastructure details, so the two docs don't duplicate or drift.Also touches up the skill: renames "Command tests" → "Unit tests" to match repo conventions, sharpens the
selectOptiondescription (literal substring vs. regex semantics), and drops a stalepnpm --filter @sanity/cli-e2e exec vitest runsnippet in favor of the standardpnpm test:e2e.What to review
packages/@sanity/cli-e2e/README.md— new file; check that therunCli()API description, env helpers, CI section, and gotchas match the actual code inhelpers/andglobalSetup.ts..claude/skills/writing-cli-e2e-tests/SKILL.md— diff against main; the cross-references back to the README should land on real sections.AGENTS.md— single-line pointer update.Testing
Docs-only — no behavior change, no changeset (per repo convention for docs). Verified all internal links resolve.
Note
Low Risk
Docs-only changes that restructure and clarify how to run and write CLI e2e tests; no production code paths are modified.
Overview
Adds a comprehensive
packages/@sanity/cli-e2e/README.mddocumenting local/CI setup,globalSetupbehavior, therunCli()spawn vs PTY APIs, environment variables, debugging tips, and common gotchas.Refactors
.claude/skills/writing-cli-e2e-tests/SKILL.mdto focus on test-writing patterns (planning, assertions, interactiveselectOptionsemantics, unattended defaults) and cross-links to the new README for infrastructure details, and updates terminology from command tests to unit tests.Updates
AGENTS.mdto point to the standardpnpm test:e2ecommands for running individual e2e files/tests.Reviewed by Cursor Bugbot for commit a60650e. Bugbot is set up for automated code reviews on this repo. Configure here.