refactor(cli): extract init command into framework-agnostic initAction

[mttdnt]

Description

Extracts ~1100 lines of logic from the oclif InitCommand (commands/init.ts) into a framework-agnostic actions/init/initAction.ts. This is the structural refactor from PR #929 / #845, using main's current logic (no regressions).

Key changes:

• commands/init.ts is now a thin oclif wrapper: static declarations + run() that maps flags → InitOptions, calls initAction(), and catches InitError
• New InitOptions / InitContext types in types.ts with flagsToInitOptions() converter
• New InitError class replaces oclif's this.error() for non-zero exits
• Flow files (initApp, initStudio, initNextJs, scaffoldTemplate) accept options: InitOptions instead of individual flag params
• Flow files throw InitError directly instead of receiving an error callback
• bootstrapTemplate.ts unchanged (only receives computed values)

What this enables:

• Init logic can be called without oclif (e.g. from create-sanity, programmatic use)
• Cleaner separation between CLI framework concerns and business logic

What to review

• Verify the extraction is purely mechanical — no logic, control flow, or behavior changes
• initAction.ts is the main new file (~1166 lines) containing all extracted functions
• types.ts has the new InitOptions, InitContext, and flagsToInitOptions
• Each flow file's signature change: individual flag params → options: InitOptions destructuring
• errorFn adapter removed from initAction.ts since flow files now throw InitError directly

Testing

All 14 existing init test files pass with zero assertion changes, confirming behavior is identical:

• init.authentication.test.ts
• init.bootstrap-app.test.ts
• init.create-new-project.test.ts
• init.get-project-details.test.ts
• init.nextjs.test.ts
• init.plan.test.ts
• init.setup.test.ts
• init.staging-env.test.ts
• Plus 6 unit test files for bootstrap/template/etc.

Typecheck, lint, and build all pass cleanly.

---

Note

Medium Risk
Large refactor of sanity init control flow and error handling (moving from oclif this.error() to thrown InitError), which could subtly change CLI exit/early-return behavior despite intent to be mechanical.

Overview
Refactors sanity init by extracting the ~1k lines of init orchestration out of commands/init.ts into a new framework-agnostic initAction() with a typed InitOptions/InitContext interface and a flagsToInitOptions() converter.

Reworks init subflows (initStudio, initApp, initNextJs, scaffoldTemplate, plan/project/dataset helpers) to accept a single options object and to throw InitError for controlled failures; InitCommand is now a thin wrapper that resolves mcpMode, calls initAction, and translates InitError to an oclif exit code.

Adds targeted unit tests for flagsToInitOptions, InitError, and direct initAction behavior, and updates existing init command tests to align with the new error/exit semantics (including optional visibility in init telemetry).

^{Reviewed by Cursor Bugbot for commit abac9ba. Bugbot is set up for automated code reviews on this repo. Configure here.}

[claude]

Claude finished @mttdnt's task in 3m 20s —— View job

---

Review

• Gather context and read changed files
• Check for changeset
• Review key files for bugs and issues
• Post findings

---

Changeset: No changeset — correctly absent for a pure refactor with no public API change.

---

1. organizations: [] hardcoded in promptForProjectCreation call

packages/@sanity/cli/src/actions/init/project/promptForAppTemplateSetup.ts lines 102–109:

await promptForProjectCreation({
  coupon,
  isUsersFirstProject: projects.length === 0,
  organizationId,
  organizations: [],   // ← always empty
  planId,
  user,
})

promptForProjectCreation forwards organizations to promptUserForOrganization when organizationId is falsy:

const org = organizationId || (await promptUserForOrganization({organizations, user}))

promptUserForOrganization then sees organizations.length === 0 and calls promptUserForNewOrganization — forcing the user to create a new org rather than choose from existing ones.

organizationId here is typed string | undefined. The caller getProjectDetails sets it via promptUserForOrganization, which has a return chosenOrg || undefined code path that can legitimately return undefined. If that happens, this produces the wrong behaviour silently.

Fix: either assert non-nullability at the callsite, or fetch and pass the real organizations list (the same list already fetched in getProjectDetails). Fix this →

---

2. promptForProjectCreation.ts test coverage at 44.4%

The coverage report shows promptForProjectCreation.ts at 44.4% (new file). The uncovered paths include the promptUserForOrganization fallback in the new-project creation flow. Given this is on the critical sanity init path, consider adding tests for the case where organizationId is undefined and the function falls through to the org prompt.

---

Note: The datasetDefault regression flagged in the previous Cursor Bugbot review has already been addressed in commit abac9ba — defaultConfig: datasetDefault || undefined is correctly passed in both the unattended and interactive paths of promptForAppTemplateSetup.

[github-actions]

📦 Bundle Stats — @sanity/cli

Compared against main (26f0fb57)

@sanity/cli

Metric	Value	vs main (26f0fb5)
Internal (raw)	2.1 KB	-
Internal (gzip)	799 B	-
Bundled (raw)	10.94 MB	-
Bundled (gzip)	2.05 MB	-
Import time	746ms	+1ms, +0.1%

bin:sanity

Metric	Value	vs main (26f0fb5)
Internal (raw)	975 B	-
Internal (gzip)	460 B	-
Bundled (raw)	9.84 MB	-
Bundled (gzip)	1.77 MB	-
Import time	1.80s	+16ms, +0.9%

🗺️ View treemap · Artifacts

Details

• Import time regressions over 10% are flagged with ⚠️
• Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — @sanity/cli-core

Compared against main (26f0fb57)

Metric	Value	vs main (26f0fb5)
Internal (raw)	93.1 KB	-
Internal (gzip)	21.9 KB	-
Bundled (raw)	21.62 MB	-
Bundled (gzip)	3.42 MB	-
Import time	703ms	-1ms, -0.1%

🗺️ View treemap · Artifacts

Details

• Import time regressions over 10% are flagged with ⚠️
• Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — create-sanity

Compared against main (26f0fb57)

Metric	Value	vs main (26f0fb5)
Internal (raw)	976 B	-
Internal (gzip)	507 B	-
Bundled (raw)	50.7 KB	-
Bundled (gzip)	12.6 KB	-
Import time	❌ ChildProcess denied: node	-

Details

• Import time regressions over 10% are flagged with ⚠️
• Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

[github-actions]

Coverage Delta

File	Statements
packages/@sanity/cli/src/actions/init/bootstrapTemplate.ts	0.0% (±0%)
packages/@sanity/cli/src/actions/init/initAction.ts	97.1% (new)
packages/@sanity/cli/src/actions/init/initApp.ts	96.0% (±0%)
packages/@sanity/cli/src/actions/init/initError.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/initHelpers.ts	100.0% (±0%)
packages/@sanity/cli/src/actions/init/initNextJs.ts	88.8% (- 1.0%)
packages/@sanity/cli/src/actions/init/initStudio.ts	87.0% (+ 0.6%)
packages/@sanity/cli/src/actions/init/plan/getPlan.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/plan/verifyCoupon.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/plan/verifyPlan.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/project/createProjectFromName.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/project/getOrCreateDataset.ts	97.7% (new)
packages/@sanity/cli/src/actions/init/project/getOrCreateProject.ts	95.3% (new)
packages/@sanity/cli/src/actions/init/project/getProjectDetails.ts	89.5% (new)
packages/@sanity/cli/src/actions/init/project/getProjectOutputPath.ts	60.0% (new)
packages/@sanity/cli/src/actions/init/project/promptForAppTemplateSetup.ts	95.2% (new)
packages/@sanity/cli/src/actions/init/project/promptForProjectCreation.ts	44.4% (new)
packages/@sanity/cli/src/actions/init/project/promptUserForNewOrganization.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/project/promptUserForOrganization.ts	100.0% (new)
packages/@sanity/cli/src/actions/init/scaffoldTemplate.ts	100.0% (+ 10.7%)
packages/@sanity/cli/src/actions/init/types.ts	100.0% (new)
packages/@sanity/cli/src/commands/init.ts	100.0% (+ 4.9%)
packages/@sanity/cli/src/telemetry/init.telemetry.ts	100.0% (±0%)

Comparing 23 changed files against main @ 26f0fb5774c142df2722ec3b4cd299e7419abf46

Overall Coverage

Metric	Coverage
Statements	84.1% (+ 0.1%)
Branches	74.0% (+ 0.1%)
Functions	84.0% (+ 0.0%)
Lines	84.5% (+ 0.1%)

[binoy14]

Looks good overall, smaller comments

[binoy14]

this naming style is weird for the describe block

[binoy14]

can this just be a static import?

[binoy14]

🤔 if useTypescript is boolean is the conditional needed?

[binoy14]

For better readability does it make sense to split this files by functions aka move some functions out of here so it's not 1k lines

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 401d4a8. Configure here.}