fix: pin constraints to sapcc/requirements stable/2025.2-m3#134
Open
notque wants to merge 1 commit into
Open
Conversation
Switch from upstream openstack/requirements master (which pins unreleased packages) to sapcc/requirements stable/2025.2-m3. This aligns with the constraint branch used by other SAP CC OpenStack services (ironic, glance, keystone, etc.). Also rename the env var from UPPER_CONSTRAINTS_FILE to TOX_CONSTRAINTS_FILE, matching the convention used across all SAP CC service repos.
notque
requested review from
Kuckkuck,
LeoZhangZXZ,
ashifnihalb,
ibakshay,
joluc,
notandy,
olandr,
richardtief,
timojohlo,
trouaux and
viennaa
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sapcc/requirements/stable/2025.2-m3instead of upstreamopenstack/requirementsmaster, which pins unreleased packages (e.g.keystoneauth1===5.14.0) and causes install failuresUPPER_CONSTRAINTS_FILEtoTOX_CONSTRAINTS_FILEto match the convention used by all other SAP CC OpenStack servicesContext
The previous default URL (
git.openstack.org) was decommissioned in 2019 and redirects via 302. Theopendev.orgmaster branch pins packages that haven't been released to PyPI yet. Usingsapcc/requirementsstable releases (the same constraints consumed by nova, neutron, keystone, ironic, glance, etc.) ensures reproducible installs.Test plan
tox -e py3— 76 tests passtox -e pep8— flake8 + bandit clean