handle broader Exception when image_pull_from_url fails#45
Open
leust wants to merge 1 commit into
Open
Conversation
There can be more than VimFaultException thrown here, i.e. ConnectionRefusedError. By catching `Exception` we make sure that we always fallback to the HttpNfcLease upload, avoiding the volume going to error state. The log was missing a string placeholder for the exception, causing a "TypeError: not all arguments converted during string formatting". Change-Id: Ib81eca79210cdbcfe47f50914f1775f07e54de57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be more than VimFaultException thrown here, i.e. ConnectionRefusedError. By catching
Exceptionwe make sure that we always fallback to the HttpNfcLease upload, avoiding the volume going to error state.The log was missing a string placeholder for the exception, causing a "TypeError: not all arguments converted during string formatting".
Change-Id: Ib81eca79210cdbcfe47f50914f1775f07e54de57