Open
Conversation
Declare retryCount as final, and use a local variable instead.
caughtThrowable could have been not initialized. E.g. if retryCount is 1, and the first execution failed, it would have thrown null.
Contributor
|
@mehmetg Could you please review? |
| base.evaluate(); | ||
| return; | ||
| } catch (Throwable t) { | ||
| if (retryCount.get() > 0 && description.getAnnotation(Retry.class)!= null) { |
Contributor
There was a problem hiding this comment.
Wouldn't adding a "=" to the first comparison fix or pulling out the assignment to caughtThrowable from within the if statement? Just like the refactored code does.
Contributor
|
The point is valid, just don't see a reason for the rewrite this fix can be handled, with a single line change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following unit test shows the bug: