Skip to content

test(kiro): fix CI typecheck in derived-span test (#108) - #109

Closed
sblattj wants to merge 1 commit into
mainfrom
fix/kiro-events-test-typecheck
Closed

sblattj wants to merge 1 commit into
mainfrom
fix/kiro-events-test-typecheck

Conversation

@sblattj

@sblattj sblattj commented Oct 1, 2026

Copy link
Copy Markdown
Owner

CI on main fails Typecheck (TS2345) on all six node/OS jobs: tests/kiro-events.test.ts:730-734 passes { agent: 'kiro' } to AtifWriter.fromEvents, which requires version and modelName.

Passes the full options. Test-only; no runtime change. npm run typecheck clean, tests/kiro-events.test.ts 42 pass.

🤖 Generated with Claude Code

Fixes the CI typecheck failure introduced with the #108 derived-span test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sblattj

sblattj commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

Superseded: main already fixed these three AtifWriter.fromEvents calls in 22dea24 (fix(tests): type the kiro ATIF fromEvents options), and typecheck has been green since. Closing as redundant.

@sblattj sblattj closed this Oct 6, 2026
@sblattj
sblattj deleted the fix/kiro-events-test-typecheck branch October 6, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant