fix(login): properly encode redirect URL#5478
Open
utafrali wants to merge 4 commits intoscaleway:mainfrom
Open
fix(login): properly encode redirect URL#5478utafrali wants to merge 4 commits intoscaleway:mainfrom
utafrali wants to merge 4 commits intoscaleway:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5478 +/- ##
==========================================
- Coverage 51.16% 51.16% -0.01%
==========================================
Files 324 324
Lines 75683 75685 +2
==========================================
Hits 38726 38726
- Misses 35480 35482 +2
Partials 1477 1477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jremy42
approved these changes
Apr 13, 2026
Member
|
@utafrali thanks a lot :) could you sign your commits? |
Author
|
Done, pushed the fix. |
Member
|
@utafrali Could you ensure that github knows your key for the signature here: https://github.com/settings/keys Otherwise, we won't be able to merge your contribution. |
Author
|
Got it, adding the key to my GitHub settings now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The callback URL in the login flow wasn't getting properly URL-encoded when passed as a query parameter. The auth server was rejecting the redirect because of the unescaped special characters. Switched to using
url.Valuesto handle the encoding instead of raw string concatenation.Related issues
Fixes #5477
Release note
Fixed login flow redirect URL encoding issue that was causing "Invalid App to redirect" errors.