SP-3501 Window size fix - #161
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesThe application persists window size, position, maximized state, and fullscreen state. Startup restores saved geometry within the active screen, and shutdown saves it before close. The changelog documents release Window Geometry Persistence
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Config
participant main
participant App
participant WailsWindow
Config-->>main: return persisted WindowBounds
main->>WailsWindow: set initial size and window state
App->>WailsWindow: restore valid position and size
WailsWindow->>App: provide geometry before close
App->>Config: persist WindowBounds
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app.go`:
- Around line 155-159: Update the close-handling logic around GetWindowBounds to
check its success result before copying geometry into bounds or persisting it.
When no normal bounds exist, avoid saving or restoring the zero-sized rectangle;
otherwise preserve the existing valid normal geometry behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be0f09ae-2ed4-49fc-a254-a1a9eaa101b3
📒 Files selected for processing (3)
CHANGELOG.mdapp.gointernal/config/config.go
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
|
@coderabbitai review |
✅ Action performedReview finished.
|
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
SCANOSS SCAN Completed 🚀
View more details on SCANOSS Action Summary |
Summary by CodeRabbit