Add MIR/PMI to paper; trim to ~1500 words - #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #201.
Added
AMICA.mir()/.pmi(),pamica/metrics/, docs indocs/api/metrics.md).Trimmed 1769 -> 1493 words
Via an independent
manuscript:paper-review(Sonnet) focused on cuts. JOSS papers target 250-1750 words, so this is well within range now. Cuts removed cross-section redundancy (the ~1e-15 score-function figure, "byte-identical EEGLAB I/O", and the float32/four-to-five-sig-digit fact were each stated 3-4 times; now stated once in their natural home), docs-level method detail (config-file specifics, version pins, per-run counts), and a table-narrating benchmark paragraph (Table 2 already carries the numbers). All load-bearing caveats kept (single subject, not core-matched, MLX-on-laptop, the multi-model iteration-budget limitation).Fixed two accuracy issues the review caught
$k$was used six times but never defined; now defined at first use ("frames per squared channel count").Body 1493 words, no em-dashes; Draft PDF CI validates the build.