Harden deep worktree process fixtures - #575
Merged
Merged
Conversation
coneilen
force-pushed
the
coneilen-microsoft-fix-deep-worktree-fixtures
branch
5 times, most recently
from
October 2, 2026 01:43
3dcd803 to
a2c9594
Compare
Signed-off-by: Colin Neilens <coneilen@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
coneilen
force-pushed
the
coneilen-microsoft-fix-deep-worktree-fixtures
branch
from
October 2, 2026 03:41
a2c9594 to
c0f3a8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Windows WorktreeGitProcess fixtures reliable from app-managed deep worktrees by keeping immutable evidence under the checkout while moving disposable executables, caches, TEMP/TMP, and Git repositories to a bounded short per-run root.
Closes #561.
Changes
FixtureDirectoryfor all disposable process-test state and clean it after every run.Test plan
The checkout root was 112 characters. Before the fix, the focused case root reached 218 characters and failed during
git init. The corrected focused run used a 28-character fixture root with a 131-character longest projected Git metadata path. The final full run used a 27-character fixture root with a 130-character projection.An initial post-pass wrapper expected a 138-character projection instead of the measured 130 and returned failure after the suite itself passed; the corrected focused run below is the canonical GREEN evidence.
RED: pwsh -NoProfile -File Tools\windows\Tests\WorktreeGitProcess.Tests.ps1 -Zig C:\gc561-tools-ac495172\zig-0.15.2\zig.exe -EvidenceDirectory graphcode-windows.zig-cache\worktree-process-red-561 -Cases scope-config-count -> 1 process regression case failed at a 218-character fixture root
GREEN: pwsh -NoProfile -File Tools\windows\Tests\WorktreeGitProcess.Tests.ps1 -Zig C:\gc561-tools-ac495172\zig-0.15.2\zig.exe -EvidenceDirectory graphcode-windows.zig-cache\worktree-process-green2-561 -FixtureDirectory C:\gc561-run-green2-ac495172 -Cases scope-config-count -> requested=1 rejection=4 executed=5 PASS
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\WorktreeGitProcess.Tests.ps1 -Zig C:\gc561-tools-ac495172\zig-0.15.2\zig.exe -EvidenceDirectory graphcode-windows.zig-cache\worktree-process-regression2-561 -FixtureDirectory C:\gc561-run-final-ac495172 -> requested=17 rejection=4 executed=21 PASS with 21 immutable case logs
Also verified that a 263-character projected Git metadata path fails before evidence creation with the path-budget diagnostic, overlapping evidence/fixture roots are rejected, both PowerShell files parse,
git diff --checkpasses, and the Windows shell eight-shard plan builds successfully.make testandmake checkwere not run because this is a Windows-only PowerShell validation-harness change; the focused and adjacent executable fixture suites above cover the changed behavior.Checklist
git commit -s) per the DCOmake test)make check)