Make Nod graph-aware: MCP server, plan to composite, forks, graph verbs, chat pane components - #588
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
Signed-off-by: scgopi <scgopireddy@gmail.com>
scgopi
force-pushed
the
feat/nod-graph-layer
branch
from
October 2, 2026 15:11
fc3c952 to
6894ed5
Compare
Signed-off-by: scgopi <scgopireddy@gmail.com> # Conflicts: # NodRuntime/PROTOCOL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes GraphCode Nod graph-aware: the built-in
graphcodeMCP server, the Swift graph logic behind plan → Composite, forks,/handoff/ask/promoteand inbound mail, and the chat pane's graph components. Stacked on #583 (feat/nod-foundation); retarget tomainonce that merges.Changes
NodRuntime/src/mcp/, zero dependencies):siblings,edges,handoff_briefs,mailroom,mailroom_read(read-only, the cursor never moves), plusaskandhandoff, gated per call byNodSettings.messagesOtherLoops. Draft for me emitsmailDraftand sends nothing, Send sendsmessageNodeas this loop, Never refuses. Reads and writes go through graphcoded's socket, the same RPC the CLI speaks, never the graph file. Also exportssendDraft(for the control socket'ssendDraft) andclassifyInbound.NodProtocol.swift+PROTOCOL.mdtogether, announced on the mailroom #1202):NodPlanStep.doneCheck(absent = false),NodBrief(--inherit <path>, fresh starts only), MCP section.LoopLineageonLoopNode/NodeDraft(fork|compositeChild, source, brief path). It isn't anEdgeKind, so older apps still decode the graph (unknown kinds decode to nil). It survivesreIdentified().NodCompositePlan): steps are grouped by the area their files touch (first non-generic directory,FooTestsfolded ontoFoo). Steps that share an area merge, and steps with no files follow the step before them. The done-check step becomes the composite's check, and each group becomes a Nod goal child briefed from the planning transcript.NodFork): same type and goal, and its own worktree on<branch>-forkN, cut from the source's branch. The brief carries the fork point. The canvas draws a dotted "forked from" line (ForkLineView).NodGraphVerb,NodInboundMailandNodHandoffOfferare inIPC/NodGraphVerbs.swift, because they buildGraphCommands and the portableDomain/has no IPC.NodGraphContextandNodEditablePlanare inDomain/.Features/Nod/GraphLayer/):NodContextStrip(renders nothing with no neighbours),NodInlineMailCard(Send reply / Edit / Answer myself),NodHandoffOfferView,NodPlanCard(drag to reorder, a rewrite marks the stepeditedByHuman, a done-check toggle, Run here / Run as Composite · N loops), andNodGraphActions, which writes briefs, creates the worktree and sends commands, gated onFeatureRamps.nod.Follow-ups owned elsewhere and agreed over the mailroom:
NodGraphSlotsin whichever PR merges second.inheritFile: node.lineage?.briefPathfromarguments(forNode:)only.createGraphcodeToolsinsrc/engine.ts.Test plan
Gate on ecc5ce5 (= remote head), private DerivedData:
xcodebuild testgraphcode-clibuildgraphcodedbuildswift test --package-path investigation/spikes/swift-portable)RED: xcodebuild test -only-testing:graphcodeTests/NodCompositeGroupingTests with the foundation's Domain sources and no GraphLayer folder -> exit 65, cannot find 'NodGraphActions' in scope, cannot find 'NodFork' in scope
GREEN: xcodebuild test -scheme graphcode (NodCompositeGroupingTests, NodForkTests, NodGraphVerbTests, NodInboundMailTests, NodGraphActionsTests and 4 more) -> pass
REGRESSION: xcodebuild test -scheme graphcode full suite, 2043 tests, plus bun test src/mcp 20 tests and tsc --noEmit -> pass
TypeScript RED:
bun test src/mcpagainst the foundation's NodRuntime fails withCannot find module './daemon'.Checklist
git commit -s) per the DCOmake check)