Launch pane-started Nod loops with their lineage, like the daemon - #607
Merged
Merged
Conversation
A pane can start a Nod session before graphcoded does. It now passes the lineage brief with --inherit on a fresh start only (never on resume) and launches a composite child --unattended, matching ZmxSessionLauncher.nodArguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: scgopi <scgopireddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the #600 review: a Nod loop whose session the app pane starts (a turn-based fork, or a pane that wins the race with graphcoded) launched without its lineage.
GhosttyTerminalView.lineageLoopWorkspaceViewnodLaunchPrefix(fresh:)--inherit <brief>on a fresh start only;--unattendedfor timed loops and composite children, matchingZmxSessionLauncher.nodArgumentsresumeCommandfresh: false, so a resumed conversation never replays its briefEvidence
RED: NodLaunchArgumentTests.aPaneStartedNodLoopCarriesItsLineageLikeTheDaemon on origin/main -> compile failure, GhosttyTerminalView has no lineage and launchPrefix no fresh: parameter
GREEN: xcodebuild test -only-testing NodLaunchArgumentTests + CopilotVersionTests -> exit 0, 23 tests passed
REGRESSION: full xcodebuild test -> 2211 tests, only MessageDeliveryTests.aSessionWhoseTaskEndedIsNeverTypedInto fails, which fails identically on main on this Mac; cli and daemon builds exit 0; make check 0 errors; swift-portable exit 0