Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc42ae02-a736-4bad-a084-8a3cf0c9cde5 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
2 tasks
Collaborator
Author
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the right loop panel so text bounds come from the panel/container instead of a fixed canvas edge, and reshape the panel toward the macOS reference with a
THIS LOOPminimap and aHANDS OFF TOlist.Changes
GraphCanvas.zigwith container-derived text bounds.THIS LOOP,HANDS OFF TO, and astarted <time>footer.Test plan
RED: zig test src\GraphCanvas.red.zig --test-filter "bounded text rectangles" -target x86_64-windows-msvc -lc "-IC:\gcp\b\winghostty\include" --cache-dir C:\gcs\b\cache --global-cache-dir C:\gcs\b\global -> throwaway GraphCanvas.red.zig snapshot reproduces the fixed 1200px text edge; expected 1762, found 1200
GREEN: zig test src\GraphCanvas.zig -target x86_64-windows-msvc -lc "-IC:\gcp\b\winghostty\include" --cache-dir C:\gcs\b\zig-cache --global-cache-dir C:\gcs\b\zig-global -> All 219 tests passed.
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart unit -SkipTrayLive -ShellValidationRoot C:\gc-b -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe -> All 167 tests passed; WINDOWS_SHELL_DEFAULT_PROFILE_UNCHANGED=verified; GDIPLUS_STARTUP_LIVE: PASS
Not verified
Tools\windows\Tests\ScrubbedShellStartup.Live.Tests.ps1:250withregistered-project did not show the registered daemon project row; exact-head CI on this PR passed that gate, includingregistered-projectand the UIA live gate, so this local failure is being treated as a local-environment issue.Unable to start graphcoded.exe; I did not get usable before/after screenshots from this machine.Tools\windows\validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLivestill needs the desktop lease for the live smoke, tray, and UI Automation checks if we want a local rerun.GraphCanvas.red.zigsnapshot that restores the original fixed 1200px text edge.Checklist
git commit -s) per the DCOmake test)make check)GraphCanvas.red.zigsnapshot before keeping the implementation