Repository navigation
Conversation
coneilen
force-pushed
the
coneilen-microsoft-wave1-d-quick-chat
branch
5 times, most recently
from
October 14, 2026 12:13
8874cd0 to
a0ef04c
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f073d0e-2c12-43fc-bfed-4ab3c4867b37 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f073d0e-2c12-43fc-bfed-4ab3c4867b37 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f073d0e-2c12-43fc-bfed-4ab3c4867b37 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f073d0e-2c12-43fc-bfed-4ab3c4867b37 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f073d0e-2c12-43fc-bfed-4ab3c4867b37 Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Scope the Quick Chat workspace to its own bar and persist its creation timestamp. Refs scgopi#774 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Use the current-main loop detail bounds and load the Quick Chat row through the protocol fixture in the workspace regression. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Limit Quick Chat panel suppression to the active chat workspace so returning to Graph can reopen the loop panel. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Publish the chat bar and its actions independently of a project graph, with a regression covering the graph-less workspace path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Clear the chat-scoped workspace when returning to the graph and prevent toggles from restoring it until the user selects a project or loop. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3072b347-66bd-4d89-8c59-71a1f6f4a33d Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
force-pushed
the
coneilen-microsoft-wave1-d-quick-chat
branch
from
October 14, 2026 14:02
624bff1 to
29b4e3e
Compare
Open
2 tasks
Collaborator
Author
|
Closed unmerged by operator decision (2026-10-14). Wave 1 was stopped and is being restarted from current |
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows Quick Chat workspace so dismissing a chat cannot restore its chat-scoped workspace or the previous loop's bar and panel when workspace toggles are used. Refs #774.
Changes
LoopWorkspaceLoopBar.swift:112-113paints the button for unresolved nodes, whileAppFeature+LoopSessions.swift:105-107intentionally does nothing for Quick Chats. Windows paints and publishes theworkspace-restart-session-UIA action; it is a visible no-op for chats, as documented by macOS: Quick Chat loop bar shows a Restart session button that does nothing #804.GraphCanvas.loopDetailSparklineBoundsandGraphCanvas.loopDetailFooterBoundsaccessibility geometry after the rebase regression.Test plan
RED: zig.exe test src\App.zig --test-filter "opening a quick chat after a loop workspace selects the chat bar through its UIA item" on origin/main -> expected chat-1, found loop-a; 0 passed, 1 failed (behavioral).
GREEN:
& $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c C:\gcp\d2\winghostty\zig-out\lib\winghostty-win32-host.lib -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp -IC:\gcp\d2\winghostty\include zig-out\lib\ghostty-vt-static.lib --cache-dir C:\gcs\d2\postpush-focused\cache --global-cache-dir C:\gcs\d2\postpush-focused\global-cache --test-filter "quick chat workspace"-> 2/2 passed on 29b4e3e.REGRESSION:
& $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c C:\gcp\d2\winghostty\zig-out\lib\winghostty-win32-host.lib -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp -IC:\gcp\d2\winghostty\include zig-out\lib\ghostty-vt-static.lib --cache-dir C:\gcs\d2\postpush-focused\cache --global-cache-dir C:\gcs\d2\postpush-focused\global-cache --test-filter "DPI UIA"-> 3/3 passed on 29b4e3e.The same App test root and pinned dependencies passed with
--test-filter "chat-bound workspace"(1/1) and--test-filter "loop detail UIA rectangles"(1/1), also on 29b4e3e. Logs:C:\gcs\d2\postpush-focused\quick-chat.log,chat-bound.log,loop-detail.log, anddpi-uia.log.The native Restart-session contract test was run before and after the provider AutomationId mapping: RED was 208 checks with 2 expected failures (missing stable AutomationId and canvas-card-count invariant); GREEN was 208 checks, 0 failures. Exact-head shard-0 CI is pending after this push and will exercise the test wired by #802.
The last desktop full-unit run was on 624bff1: 1201/1201 tests and 55/55 sections completed, but the command exited 1 only because the #802 harness cleanup hit a
Remove-Itemrace. #805 fixes that cleanup path; a current-head full-ShellPart unitrun is still pending its desktop slot and is not claimed as passing.Not verified
-ShellPart unitrun inside a desktop slot remains pending. The previous run's default-profile guard used a process-scoped scratch profile and the real-folder validation rootC:\gc-d2.WorktreeGitProcess case=removalsfailure remains unattributed. A later run passed that case under the realC:\gc-d2root, but that does not establish the earlier failure's cause.make testandmake checkwere not run; they are macOS validation commands and do not cover this Windows change.Checklist
git commit -s) per the DCOmake test)make check)